Alan, done (in-place)
http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ -Dmitry On 2016-03-29 11:21, Alan Bateman wrote: > > > On 29/03/2016 09:15, Dmitry Samersoff wrote: >> Everybody, >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/ >> >> Webrev updated (in-place, press shift-reload). >> >> VirtualMachineImpl.bootClassPath() returns Collections.emptyList() >> rather than throw an exception. >> >> > This looks okay except for the confusing comment "This function is > required to implement com.sun.jdi.PathSearchingVirtualMachine > interface". The class implements the interface so I think this comment > can be removed. > > For completeness then you could change the return type to List<String>. > > -Alan -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
