On 3/30/16 01:50, Dmitry Samersoff wrote:
Serguei,

Thank you for review!

These tests are not part of any testing process. I plan to review and
fix/delete it as necessary under a separate CR (JDK-8146200)

Ok, reviewed.


Thanks,
Serguei



-Dmitry

On 2016-03-30 11:28, [email protected] wrote:
Hi Dmitry,

Looks good in general.

The following files in the jdk.hotspot.agent/test folder may need to be
updated too:
   src/jdk.hotspot.agent/test/jdi/runjdb.sh
   src/jdk.hotspot.agent/test/jdi/runsa.sh

Thanks,
Serguei


On 3/29/16 02:41, Alan Bateman wrote:

On 29/03/2016 09:54, Dmitry Samersoff wrote:
Alan,

done (in-place)

http://cr.openjdk.java.net/~dsamersoff/JDK-8150973/webrev.02/

-Dmitry


Looks okay to me. At some point (and nothing to do with this change)
is that we should add type parameters to the other methods like
getPath, classPath, etc.

-Alan


Reply via email to