Sharath, Looks good for me.
Please, move LingeredAppWithExtendedChars.java to the test directory, it's test-specific code and it shouldn't be in the library (no need for re-review). -Dmitry On 2016-08-17 19:12, Sharath Ballal wrote: > Hello Dmitry, > Thanks for the review. I have done the changes, pls have a look: > > http://cr.openjdk.java.net/~sballal/8163346/webrev.01/ > > -Sharath Ballal > > > -----Original Message----- > From: Dmitry Samersoff > Sent: Wednesday, August 10, 2016 1:16 PM > To: Sharath Ballal; serviceability-dev@openjdk.java.net > Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for > better diagnostic of timeout. > > Sharath, > > As soon as you request a heap dump of LingeredApp, LingeredApp should > contains the object with extended characters in it's name. > > So please: > > 1. Inherit LingeredApp (See LingeredAppWithDeadlock as an example) and add > > public static int \u00CB = 1; > > 2. Copy BasicLauncherTest to HeapDumpWitExtCharsTest.java and change it > according to you needs (i.e. remove everything but > heapDumpTest) > > 3. Remove Test8028623.java > > -Dmitry > > > On 2016-08-08 12:37, Sharath Ballal wrote: >> Hello, >> >> Pls review the following fix for modifying the testcase >> jmap-hashcode/Test8028623.java to use LingeredApp. >> >> >> >> http://cr.openjdk.java.net/~sballal/8163346/webrev.00/ >> >> >> >> Link to bug: https://bugs.openjdk.java.net/browse/JDK-8163346 >> >> >> >> -Sharath Ballal >> >> >> >> >> > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
