Thanks David.
-Sharath Ballal -----Original Message----- From: David Holmes Sent: Thursday, August 25, 2016 5:56 PM To: Sharath Ballal; Dmitry Samersoff; serviceability-dev@openjdk.java.net Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for better diagnostic of timeout. Hi Sharath, I've taken a look at this refactoring of the test and it seems okay. Thanks, David On 25/08/2016 8:14 PM, Sharath Ballal wrote: > Dmitry has reviewed this fix of changes in the testcase. Could anybody else > review it as a second reviewer ? > > > -Sharath Ballal > > > > -----Original Message----- > From: Sharath Ballal > Sent: Monday, August 22, 2016 9:57 PM > To: Dmitry Samersoff > Cc: Arvind Aprameya > Subject: RE: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for > better diagnostic of timeout. > > Hi Dmitry, > > I have made the suggested changes. As discussed, I have also excluded > HeapDumpTest.java from running on MAC OS to avoid hitting > JDK-8160376 - DebuggerException: Can't attach symbolicator to the > process > > Webrev: http://cr.openjdk.java.net/~sballal/8163346/webrev.02/ > > Rbt: > https://jdash.se.oracle.com/rbt/rbt-sharath.ballal-dev_agentpath-20160 > 822-0952-21583 > > > -Sharath Ballal > > > -----Original Message----- > From: Dmitry Samersoff > Sent: Friday, August 19, 2016 3:51 PM > To: Sharath Ballal; serviceability-dev@openjdk.java.net > Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for > better diagnostic of timeout. > > Sharath, > > Looks good for me. > > Please, move LingeredAppWithExtendedChars.java to the test directory, it's > test-specific code and it shouldn't be in the library (no need for re-review). > > -Dmitry > > On 2016-08-17 19:12, Sharath Ballal wrote: >> Hello Dmitry, >> Thanks for the review. I have done the changes, pls have a look: >> >> http://cr.openjdk.java.net/~sballal/8163346/webrev.01/ >> >> -Sharath Ballal >> >> >> -----Original Message----- >> From: Dmitry Samersoff >> Sent: Wednesday, August 10, 2016 1:16 PM >> To: Sharath Ballal; serviceability-dev@openjdk.java.net >> Subject: Re: RFR: JDK-8163346: Update jmap-hashcode/Test8028623.java for >> better diagnostic of timeout. >> >> Sharath, >> >> As soon as you request a heap dump of LingeredApp, LingeredApp should >> contains the object with extended characters in it's name. >> >> So please: >> >> 1. Inherit LingeredApp (See LingeredAppWithDeadlock as an example) >> and add >> >> public static int \u00CB = 1; >> >> 2. Copy BasicLauncherTest to HeapDumpWitExtCharsTest.java and change >> it according to you needs (i.e. remove everything but >> heapDumpTest) >> >> 3. Remove Test8028623.java >> >> -Dmitry >> >> >> On 2016-08-08 12:37, Sharath Ballal wrote: >>> Hello, >>> >>> Pls review the following fix for modifying the testcase >>> jmap-hashcode/Test8028623.java to use LingeredApp. >>> >>> >>> >>> http://cr.openjdk.java.net/~sballal/8163346/webrev.00/ >>> >>> >>> >>> Link to bug: https://bugs.openjdk.java.net/browse/JDK-8163346 >>> >>> >>> >>> -Sharath Ballal >>> >>> >>> >>> >>> >> >> >> -- >> Dmitry Samersoff >> Oracle Java development team, Saint Petersburg, Russia >> * I would love to change the world, but they won't give me the sources. >> > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources. >