Thank you, Ioi. -jini
> -----Original Message----- > From: Ioi Lam > Sent: Tuesday, September 13, 2016 9:47 PM > To: Jini Susan George; Dmitry Samersoff; serviceability-dev > Subject: Re: RFR: 8027920: SA: Add default methods to InstanceKlass > > Hi Jini, > > Looks good. Thanks > - Ioi > > On 9/13/16 4:24 AM, Jini Susan George wrote: > > Thank you, Ioi and Dmitry, for your comments. Please check the new > webrev addressing these comments at: > > > > http://cr.openjdk.java.net/~jgeorge/8027920/webrev.01/index.html > > > > Thanks, > > Jini. > > > >> -----Original Message----- > >> From: Dmitry Samersoff > >> Sent: Sunday, September 11, 2016 2:43 PM > >> To: Jini Susan George; serviceability-dev > >> Subject: Re: RFR: 8027920: SA: Add default methods to InstanceKlass > >> > >> Jini, > >> > >> SA changes looks good for me. > >> > >> In testcase, please use LingeredApp derived class (see > >> LingeredAppWithDeadlock as an example) rather that attach to self. > >> > >> -Dmitry > >> > >> On 2016-09-11 09:01, Jini Susan George wrote: > >>> Hello, > >>> > >>> > >>> > >>> Could I please get a review for the following fix ? > >>> > >>> > >>> > >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8027920 > >>> > >>> Webrev: http://cr.openjdk.java.net/~jgeorge/8027920/webrev.00/ > >>> > >>> > >>> > >>> Thanks, > >>> > >>> - Jini Susan George > >>> > >>> > >>> > >> > >> -- > >> Dmitry Samersoff > >> Oracle Java development team, Saint Petersburg, Russia > >> * I would love to change the world, but they won't give me the sources. >
