Jini, Looks good for me!
-Dmitry On 2016-09-13 19:32, Jini Susan George wrote: > Thanks again, Dmitry. Modified webrev: > > http://cr.openjdk.java.net/~jgeorge/8027920/webrev.02/ > > Rgds, > -Jini > >> -----Original Message----- >> From: Dmitry Samersoff >> Sent: Tuesday, September 13, 2016 5:36 PM >> To: Jini Susan George; serviceability-dev; Ioi Lam >> Subject: Re: RFR: 8027920: SA: Add default methods to InstanceKlass >> >> Jini, >> >> 1. It might be better to move LingeredAppWithDefaultMethods.java >> to test folder, hotspot/test/serviceability/sa/ >> >> 2. LingeredAppWithDefaultMethods.java 25 >> >> java.util.concurrent.Phaser is not used, >> >> 3. TestDefaultMethods.java >> >> It might be better to move pid conversion to a corresponding function >> to have better error message in case of conversion error. >> >> i.e. >> Integer.parseInt(args[0]) >> => printDefaultMethods(String pid, ... ) >> >> Long.toString(theApp.getPid()) >> => createAnotherToAttach( ..., long pid, ...) >> >> >> -Dmitry >> >> On 2016-09-13 14:24, Jini Susan George wrote: >>> Thank you, Ioi and Dmitry, for your comments. Please check the new >> webrev addressing these comments at: >>> >>> http://cr.openjdk.java.net/~jgeorge/8027920/webrev.01/index.html >>> >>> Thanks, >>> Jini. >>> >>>> -----Original Message----- >>>> From: Dmitry Samersoff >>>> Sent: Sunday, September 11, 2016 2:43 PM >>>> To: Jini Susan George; serviceability-dev >>>> Subject: Re: RFR: 8027920: SA: Add default methods to InstanceKlass >>>> >>>> Jini, >>>> >>>> SA changes looks good for me. >>>> >>>> In testcase, please use LingeredApp derived class (see >>>> LingeredAppWithDeadlock as an example) rather that attach to self. >>>> >>>> -Dmitry >>>> >>>> On 2016-09-11 09:01, Jini Susan George wrote: >>>>> Hello, >>>>> >>>>> >>>>> >>>>> Could I please get a review for the following fix ? >>>>> >>>>> >>>>> >>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8027920 >>>>> >>>>> Webrev: http://cr.openjdk.java.net/~jgeorge/8027920/webrev.00/ >>>>> >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> - Jini Susan George >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dmitry Samersoff >>>> Oracle Java development team, Saint Petersburg, Russia >>>> * I would love to change the world, but they won't give me the sources. >> >> >> -- >> Dmitry Samersoff >> Oracle Java development team, Saint Petersburg, Russia >> * I would love to change the world, but they won't give me the sources. -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
