On 9/20/16 15:21, Daniel D. Daugherty wrote:
On 9/20/16 12:33 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
Still can't say that I'm really any good at reviewing XML or XSL.
I had a good practice but still can't say that. :-)
As long as you are happy with the new generated file... :-)
I'm happy as the generated comment is correct and this version
(I wrote two of them) is simpler than previous one.
Thank you so much, Dan!
The problem is that the
is currently generated with the GPL copyright comment.
The JDK version of the header that we ship must havethe GPL +
So that the file is taken from the version that is checked into the
Now, the checked-in version of the jvmti.h in the jdk repository is
from the jvmvtifiles/jvmti.h with the copyright comment replacement
Replacement of the copyright comment in the jvmvtifiles/jvmti.h was
Alan and Iris, and they are Ok with the change.
The jvmti.h is generated from the
hotspot/src/share/vm/prims/jvmti.xml with the XSL scripts,
and its copyright comment is inherited from the jvmti.xml.
The fix is to update the XSL scripts to generate the GPL+CP
The only part that is still taken from the jvmti.xml is the
copyright year line.
There is a separate bug that targets automatic installation of the
and potential removal of the checked-in version from the jdk
Checked in jvmti.h not in sync with generated jvmti.h
Checked the copyright comment in the generated