Sharath, Looks good to me.
Minor nit: Reader.java:125 you can create an instance of HprofReader and avoid extra cast. -Dmitry On 2017-05-29 13:44, Sharath Ballal wrote: > Hi, > > > > Pls review the fix for including stack traces in the heap dump in SA. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-6760477 > > Webrev: http://cr.openjdk.java.net/~sballal/6760477/webrev.00/ > > > > > > Thanks & Regards, > > Sharath Ballal > > > > > -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.
