Hi Sharath,
Looks good. A few nits.
* Looks like the stackTraces array list is unused.
* HeapHprofBinWriter.java: Line 764: It might be better to replace 2 * 4
and similar instances with 2 * INT_SIZE.
Thanks,
Jini.
On 5/29/2017 4:14 PM, Sharath Ballal wrote:
Hi,
Pls review the fix for including stack traces in the heap dump in SA.
Bug: https://bugs.openjdk.java.net/browse/JDK-6760477
Webrev: http://cr.openjdk.java.net/~sballal/6760477/webrev.00/
<http://cr.openjdk.java.net/%7Esballal/6760477/webrev.00/>
Thanks & Regards,
Sharath Ballal
