Hi Ben, The fix looks good, I see no problems. Thank you for taking care about this!
I'll sponsor it. A couple of copyright comments need an update but I can fix it myself. Do I understand it right that you have no OpenJDK status yet? At least one more review is required for push. Thanks, Serguei On 10/20/17 05:57, Ben Walsh wrote:
Alan has hosted the patch for me : http://cr.openjdk.java.net/~alanb/8189731/webrev/ Regards, Ben Walsh -----Ben Walsh/UK/IBM wrote: ----- To: serviceability-dev@openjdk.java.net From: Ben Walsh/UK/IBM Date: 19/10/2017 11:07 Subject: [PATCH] Unnecessary Amount Of Internal Class Conversion Per Alan's request here (http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-October/049532.html), I am redirecting my initial email to this mailing list ... I have observed a problem where an unnecessary amount of internal class conversion is occurring. I have a patch which I would like to contribute which represents a performance optimisation for this problem in the java.instrument module implementation. It avoids having to convert all classes from a JVM's internal class format to the .class file format, in order to call the ClassFileLoadHook, when no java transformer installed. I would like to pair with a sponsor who could host and review this patch, so I can get it contributed. Regards, Ben Walsh Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
