Excellent. Thanks Serguei. That's correct. It's my first contribution.
Could you recommend someone for the second required review ? Thanks, Ben Walsh -----"serguei.spit...@oracle.com" <serguei.spit...@oracle.com> wrote: ----- To: Ben Walsh <ben_wa...@uk.ibm.com>, serviceability-dev@openjdk.java.net From: "serguei.spit...@oracle.com" <serguei.spit...@oracle.com> Date: 27/10/2017 6:42 Cc: alan Bateman <alan.bate...@oracle.com> Subject: Re: [PATCH] Unnecessary Amount Of Internal Class Conversion Hi Ben, The fix looks good, I see no problems. Thank you for taking care about this! I'll sponsor it. A couple of copyright comments need an update but I can fix it myself. Do I understand it right that you have no OpenJDK status yet? At least one more review is required for push. Thanks, Serguei On 10/20/17 05:57, Ben Walsh wrote: > Alan has hosted the patch for me : > https://urldefense.proofpoint.com/v2/url?u=http-3A__cr.openjdk.java.net_-7Ealanb_8189731_webrev_&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=0rTKw9slljsdE7-sx--lzTNyOod7e8UQH1LYkfqUvuI&m=g2uzGnK1r9fSRVv1_xM4GD7tmiC3zrARxelV9Iw5KRc&s=w53BxK8jD973k3MASlvUlnnCp1mDJR9R9jSOiDRoYGg&e= > > Regards, > > Ben Walsh > > > -----Ben Walsh/UK/IBM wrote: ----- > To: serviceability-dev@openjdk.java.net > From: Ben Walsh/UK/IBM > Date: 19/10/2017 11:07 > Subject: [PATCH] Unnecessary Amount Of Internal Class Conversion > > Per Alan's request here > (https://urldefense.proofpoint.com/v2/url?u=http-3A__mail.openjdk.java.net_pipermail_core-2Dlibs-2Ddev_2017-2DOctober_049532.html&d=DwICaQ&c=jf_iaSHvJObTbx-siA1ZOg&r=0rTKw9slljsdE7-sx--lzTNyOod7e8UQH1LYkfqUvuI&m=g2uzGnK1r9fSRVv1_xM4GD7tmiC3zrARxelV9Iw5KRc&s=-4eQ0EEyG3wyhV69AvRRNWG5ZreRsVtNHMjTDTYvtso&e=), > I am redirecting my initial email to this mailing list ... > > I have observed a problem where an unnecessary amount of internal class > conversion is occurring. > > I have a patch which I would like to contribute which represents a > performance optimisation for this problem in the java.instrument module > implementation. > > It avoids having to convert all classes from a JVM's internal class format to > the .class file format, in order to call the ClassFileLoadHook, when no java > transformer installed. > > I would like to pair with a sponsor who could host and review this patch, so > I can get it contributed. > > Regards, > > Ben Walsh > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
