Thanks Christoph for the review.
Can I get one more review please?
-Harsha
On Tuesday 05 December 2017 11:29 AM, Langer, Christoph wrote:
Hi Harsha,
this looks good to me.
Small finding: Line 366, there could be a space between if and (.
Best regards
Christoph
-----Original Message-----
From: serviceability-dev [mailto:serviceability-dev-
boun...@openjdk.java.net] On Behalf Of Harsha Wardhana B
Sent: Montag, 4. Dezember 2017 19:28
To: serviceability-dev@openjdk.java.net
Subject: [TestBug] RFR : JDK-8192909 - Invalid username or password in
HashedPasswordFileTest.java
Hi All,
Please review and provide comments for fix for,
issue: https://bugs.openjdk.java.net/browse/JDK-8192909
having webrev at,
webrev : http://cr.openjdk.java.net/~hb/8192909/webrev.00/
Fix details: The test was failing intermittently because of duplicate
entries for role in input password file. The duplicate entries get
over-written by JMX agent, but the client was testing with stale entries
for duplicated role. Also, the test now uses a single random number
generator from test package (Utils.getRandomInstance) instead of two.
Regards
Harsha
