Hi Harsha,
Looks good.
nit:
366 if(random.nextBoolean()) {
367 String[] tokens = line.split("\\s+");
368 if ((tokens.length == 4 || tokens.length == 3)) {
inverting the two if () (testing for the applicability of the line
first) would probably give a better chance that an existing
password is replaced, unless most lines are applicable.
best regards,
-- daniel
n 04/12/2017 18:27, Harsha Wardhana B wrote:
Hi All,
Please review and provide comments for fix for,
issue: https://bugs.openjdk.java.net/browse/JDK-8192909
having webrev at,
webrev : http://cr.openjdk.java.net/~hb/8192909/webrev.00/
Fix details: The test was failing intermittently because of duplicate
entries for role in input password file. The duplicate entries get
over-written by JMX agent, but the client was testing with stale entries
for duplicated role. Also, the test now uses a single random number
generator from test package (Utils.getRandomInstance) instead of two.
Regards
Harsha
