|
Hi Egor,
[adding jdk8u-dev, which is where 8u backports are discussed]
I think major.minor changed from 1.8 to 9.0, although I haven't
found the code to confirm that yet. I'm assuming this because of
the following code:
public boolean canGetModuleInfo() {
validateVM();
return versionInfo().jdwpMajor >= 9;
}
Given that, your changes look correct. I'm not an 8u reviewer.
You'll need to get the official ok from someone on the 8u list.
thanks,
Chris
On 2/5/18 7:44 AM, Egor Ushakov wrote:
Hi all,
in IDEA we faced an issue that when debugging java 9 process
memory view does not work:
https://youtrack.jetbrains.com/issue/JRE-641
It seems that there's a bug in how
VirtualMachineImpl.canGetInstanceInfo checks vm version (it does
not pass jdk 9 where minor is 0):
if (versionInfo().jdwpMajor < 1 ||
versionInfo().jdwpMinor < 6) {
return false;
}
I've found this fixed in jdk 9 inside the fix:
http://hg.openjdk.java.net/jdk9/hs/rev/f900d5afd9c8
8142968: Module System implementation Summary: Initial integration
of JEP 200, JEP 260, JEP 261, and JEP 282 alanb 17-Mar-16 22:04
We've applied the part of the fix into our jdk 8 fork:
https://github.com/JetBrains/jdk8u_jdk/commit/6424e2786e8adc4e012e0b7bd0cfc78ba1ab34dd
It seems reasonable to backport at least this part into openjdk 8?
What do you think?
Maybe some other parts deserve backporting as well.
I've attached the patch just in case.
--
Egor Ushakov
Software Developer
JetBrains
http://www.jetbrains.com
The Drive to Develop
|
