Hi Daniil, Thanks for taking this on!
On 6/06/2018 4:38 AM, Daniil Titov wrote:
Please review the change that fixes vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic002/TestDescription.java test. The fix uses the implementation of a parametrized interface in the test class to trigger the compiler to generate a synthetic bridge method. The test works fine in both nestmates and jdk/jdk repositories.
This looks fine to me and I like the simplification of not having to re-list all the methods in the debuggee class in the debugger class. The test may break again in the future if compilation strategies change, but any test for synthetic methods obviously has a dependency on the compilation strategy, so that's not a concern.
Thanks, David
Issue: https://bugs.openjdk.java.net/browse/JDK-8203033 Webrev: http://cr.openjdk.java.net/~dtitov/8203033/webrev.02 Thanks, Daniil
