Re: RFR 8203033: [Testbug] vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic002/TestDescription.java fails with nestmates

[serguei.spit...@oracle.com]

Hi Daniil, It looks good. One minor comment. http://cr.openjdk.java.net/~dtitov/8203033/webrev.02/test/hotspot/jtreg/vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic002.java.frames.html 153 log.complain("debuger FAILURE 3> Method's " + name + signature 154 + " synthetic is true, but expected " 155 + "is false"); The sub-string at lines 154 and 155 can be combined into one:    + " synthetic is true, but expected is false"); But I'd suggest to simplify it to something like this:    log.complain("debugger FAILURE 3> found unexpected synthetic method " + name + signature); Also, there are many instances of the typo: debuger => debugger. Could you, please, fix it? Thank you a lot for taking care about this! Thanks, Serguei On 6/5/18 11:38, Daniil Titov wrote: Please review the change that fixes vmTestbase/nsk/jdi/TypeComponent/isSynthetic/issynthetic002/TestDescription.java test. The fix uses the implementation of a parametrized interface in the test class to trigger the compiler to generate a synthetic bridge method. The test works fine in both nestmates and jdk/jdk repositories. Issue: https://bugs.openjdk.java.net/browse/JDK-8203033 Webrev: http://cr.openjdk.java.net/~dtitov/8203033/webrev.02 Thanks, Daniil