|
Hi Jc,
It looks good to me.
Thanks,
Serguei
On 7/26/18 09:53, JC Beyler wrote:
Hi all,
As we fixed the HeapMonitorTest to not fail from time to
time, there seems to be the same issue and risk in
HeapMonitorGCTest. Could someone review the similar fix:
The risk is that the last interval is too big and no
sampled object is live after the allocation method. If a GC
happens before the check for sample code, it is possible no
live objects still exist.
The solution is to reduce the sampling interval to make it
highly unlikely for no samples to happen in any allocation
iteration, keeping at least one sampled object live. But also
check the GC'd objects in the system in case they did actually
all already get GC'd.
|
