Re: RFR (M) 8212884: Remove the assignments in ifs for vmTestbase/[a-s]

Wed, 24 Oct 2018 10:41:39 -0700

Hi JC,

Overall looks good. Just a couple of minor things. I don't need to see another webrev.

In Abort.cpp, Callbacks.cpp, ConcreteKlassFilter.cpp, HeapFilter.cpp.frames, NonConcreteKlassFilter.cpp, and threadend002.cpp.frames you need to add a space after the "if":

 130   if(!NSK_VERIFY(jvmti != NULL)) {

In em01t002.cpp, indent of 2nd line isn't correct:

  74     methodID = jni_env->GetMethodID(
  75                 klass, "loadClass", "(Ljava/lang/String;)Ljava/lang/Class;");

thanks,

Chris

On 10/24/18 9:40 AM, JC Beyler wrote:
Hi all,

Here is the first webrev to extract assignments from if test clauses. It should be relatively straightforward to review.

I tested all the tests changed and they pass on my dev machine.

Most changes were done via the script I put in the bug, I had to do a few clean-ups and corner cases as well.


Reply via email to