Hi all, For reference, after the space removal webrev has been pushed, this webrev had a tiny conflict (as Chris had guessed) in one file: test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp
You can see the old change vs the new change, it is trivial to see it is ok: - http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp.udiff.html - http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp.udiff.html The full webrev is here: Webrev: http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8212884 If I could have a final LGTM, that would be awesome! Jc On Wed, Oct 24, 2018 at 2:26 PM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Hi Jc, > > It looks great! > Your AI-enabled conversion scripts are smart! :) > > Thanks, > Serguei > > On 10/24/18 09:40, JC Beyler wrote: > > Hi all, > > Here is the first webrev to extract assignments from if test clauses. It > should be relatively straightforward to review. > > I tested all the tests changed and they pass on my dev machine. > > Most changes were done via the script I put in the bug, I had to do a few > clean-ups and corner cases as well. > > Webrev: http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.00/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8212884 > > Thanks, > Jc > > > -- Thanks, Jc
