Thanks Alex for the review! Tested & pushed, Jc
On Tue, Dec 11, 2018 at 12:21 PM Alex Menkov <alexey.men...@oracle.com> wrote: > Hi Jc, > > Thanks for the update. > LGTM. > > --alex > > On 12/10/2018 20:39, JC Beyler wrote: > > Hi Alexey, > > > > Thanks for the review! > > > > Here is the fixed version: > > > > Webrev: http://cr.openjdk.java.net/~jcbeyler/8215160/webrev.01/ > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215160 > > > > Thanks again, > > Jc > > > > > > On Mon, Dec 10, 2018 at 4:41 PM Alex Menkov <alexey.men...@oracle.com > > <mailto:alexey.men...@oracle.com>> wrote: > > > > Sorry, it was review for 8215161 > > > > Some minor notes for this webrev: > > - nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/ji05t001.cpp > > for some reason there are missed spaces before "?" in statements like > > (indx == 0)? "A" : "B" > > see lines 190, 227, 243 > > > > Also there is some inconsistency with spaces around "%" operator - > > in nsk/stress/jni/libjnistress001.cpp and > > nsk/stress/jni/libjnistress003.cpp > > there are no spaces like > > + if (allocs%printperiod == 0) { > > > > in other files the spaces are added > > like (nsk/stress/jni/libjnistress005.cpp) > > + if (Exceptcalls % 1000 == 0) > > > > --alex > > > > On 12/10/2018 14:28, Alex Menkov wrote: > > > +1 > > > > > > One minor request. > > > Could you please fix > > > nsk/jvmti/NativeMethodBind/nativemethbind002/nativemethbind002.cpp > > > replacing > > > > > > if (!(methNam == NULL)) > > > and > > > if (!(methSig == NULL)) > > > > > > with > > > if (methNam != NULL) > > > and > > > if (methSig != NULL) > > > > > > No need for new round of the review. > > > > > > --alex > > > > > > > > > On 12/10/2018 13:54, serguei.spit...@oracle.com > > <mailto:serguei.spit...@oracle.com> wrote: > > >> Hi Jc, > > >> > > >> LGTM > > >> > > >> Thank you for the re-post! > > >> Serguei > > >> > > >> > > >> On 12/10/18 13:46, JC Beyler wrote: > > >>> Hi all, > > >>> > > >>> Let's try this again; my apologies for the spam. > > >>> > > >>> Could I get a review that normalizes spaces around comparisons > and > > >>> the ternary operator? This is the second of two webrevs to > > handle this. > > >>> > > >>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8215160/webrev.00/ > > >>> <http://cr.openjdk.java.net/%7Ejcbeyler/8215160/webrev.00/> > > >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215160 > > >>> > > >>> Thanks, > > >>> Jc > > >>> > > >> > > > > > > > > -- > > > > Thanks, > > Jc > -- Thanks, Jc
