Hi Jc,
On 5/02/2019 3:47 am, Jean Christophe Beyler wrote:
Hi Jini,
The webrev looks good to me but I was wondering why you are changing the
tests really. For example:
http://cr.openjdk.java.net/~jgeorge/8217473/webrev.01/test/hotspot/jtreg/serviceability/sa/ClhsdbAttach.java.html
The main method already is declared to be throwing the top class
Exception. It seems to me that you could then skip updating the tests:
+ } catch (SkippedException se) {
+ throw se;
no?
Probably I'm missing something but seemed like you didn't need to add
this if you were just rethrowing it.
It has to be caught to be rethrown, otherwise it is caught by the
following clause (which catches all Exception types) and a
RuntimeException thrown instead.
David
-----
On Wed, Jan 30, 2019 at 8:39 PM Jini George <[email protected]
<mailto:[email protected]>> wrote:
Thank you, David!
- Jini.
On 1/31/2019 7:45 AM, David Holmes wrote:
> Hi Jini,
>
> This looks reasonable to me.
>
> Thanks,
> David
>
> On 30/01/2019 9:59 pm, Jini George wrote:
>> Requesting reviews for:
>>
>> BugID: https://bugs.openjdk.java.net/browse/JDK-8217473
>>
Webrev:http://cr.openjdk.java.net/~jgeorge/8217473/webrev.01/index.html
>>
>> The patch includes changes to use SkippedException to skip the
tests
>> when canPtraceAttachLinux() in Platform.java returns false.
>>
>> Thanks,
>> Jini.
>>
--
Thanks,
Jc
