Re: RFR: JDK-8068225: nsk/jdi/EventQueue/remove_l/remove_l005 intermittently times out

[Chris Plummer]

+1 Chris On 2/8/19 2:26 PM, Jean Christophe Beyler wrote: Hi Gary, Looks good to me too :) Thanks, Jc On Fri, Feb 8, 2019 at 10:40 AM serguei.spit...@oracle.com <serguei.spit...@oracle.com> wrote: Hi Gary, I'm Okay with the fix if the test run is good. Thanks, Serguei On 2/8/19 05:25, Gary Adams wrote: > The intermittent failures for remove_l005 appears to be due to a > timing issue > in the shutdown handling after the test has completed. The debugger > has sent > a "quit" command, but the debugee has not completed processing the > command > and exited as expected. > > This proposed change modifies the Debugee.endDebugee() processing to > wait for the debuggee to complete before doing the tear down processing > on the debugger side of the connection. This sequencing did expose > an issue in the canBeModified test, where the debugee was never resumed > after the VMStart event was detected. Resuming the debugee allows it to > respond as expected when the direct call to endDebugee is invoked. > > Testing is still in progress, but it looks like this will resolve a > number of > tail end intermittent failures. > >   Issue: https://bugs.openjdk.java.net/browse/JDK-8068225 >   Webrev: http://cr.openjdk.java.net/~gadams/8068225/webrev.00/ -- Thanks, Jc