Hi Serguei, Looks good to me too :) Jc
On Tue, Jun 4, 2019 at 6:21 PM <serguei.spit...@oracle.com> wrote: > Thanks a lot, Alex! > Serguei > > On 6/4/19 6:18 PM, Alex Menkov wrote: > > The fix looks good to me. > > > > --alex > > > > On 06/04/2019 16:30, serguei.spit...@oracle.com wrote: > >> Please, review a fix for the JVMTI spec bug: > >> https://bugs.openjdk.java.net/browse/JDK-8205126 > >> > >> Webrev: > >> > http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.1/ > >> > >> > >> > >> Related CSR: > >> https://bugs.openjdk.java.net/browse/JDK-8225142 > >> > >> Specdiff: > >> > http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8205126-jvmti-spec-popframe.1/jvmti-specdiff/ > >> > >> > >> > >> Summary: > >> The JVMTI PopFrame() spec does not match the implementation. > >> It says the specified thread can not be the current thread. > >> The fix aligns: > >> - spec with implementaion > >> - PopFrame spec with ForceEarlyReturn spec > >> > >> Thanks, > >> Serguei > > -- Thanks, Jc
