Hi JC, Thank you! I will change the comment as suggested.
Cheers, Thomas On Wed, Jun 5, 2019, 18:59 Jean Christophe Beyler <jcbey...@google.com> wrote: > Hi Thomas, > > Looks good to me. I would just nit that your example does not seem to > exist in your regex selections :) > > (e.g. "Classes redefined (0 events):"). > > but you only check for Classes unloaded for example. Perhaps you could > update the example to one of the regex you actually do check for ? > > Evidently no need of another webrev for that! > Jc > > On Wed, Jun 5, 2019 at 9:52 AM Thomas Stüfe <thomas.stu...@gmail.com> > wrote: > >> Hi all, >> >> may I have a small review please for this patch: >> >> cr: >> http://cr.openjdk.java.net/~stuefe/webrevs/8225348-eventstest-failed/webrev.00/webrev/ >> bug: https://bugs.openjdk.java.net/browse/JDK-8225348 >> >> JDK-8224600 introduced a new jcmd, VM.events, and an associated test. >> >> In run_selected(CommandExecutor executor), I want to make sure the >> "Events" log is not printed and therefore scan for "Events" on stdout, but >> that term is too broad and can be part of normal output, giving a false >> positive. >> >> Fix is to make the pattern matching more strict. >> >> Thanks, Thomas >> > > > -- > > Thanks, > Jc >
