Re: RFR(T): 8225348: serviceability/dcmd/vm/EventsTest.java failed

Wed, 05 Jun 2019 10:23:22 -0700

Looks good. Thanks for fixing quickly.

Chris

On 6/5/19 9:50 AM, Thomas Stüfe wrote:
Hi all,

may I have a small review please for this patch:

cr: http://cr.openjdk.java.net/~stuefe/webrevs/8225348-eventstest-failed/webrev.00/webrev/

JDK-8224600 introduced a new jcmd, VM.events, and an associated test. 

In run_selected(CommandExecutor executor), I want to make sure the "Events" log is not printed and therefore scan for "Events" on stdout, but that term is too broad and can be part of normal output, giving a false positive.

Fix is to make the pattern matching more strict.

Thanks, Thomas

Reply via email to