Re: RFR(S): 8225388: Running jcmd Compiler.CodeHeap_Analytics all 0 cause crash.

[serguei.spit...@oracle.com]

Hi Leonid, It looks good to me. One minor comment on the src/hotspot/share/services/diagnosticCommand.?pp + DCmdArgument<jlong> _granularity; I'm curios if using size_t instead of jlong as in other files would be more unified. Thanks, Serguei On 6/6/19 17:36, Leonid Mesnik wrote: Hi Could you please review following fix which verify parameter for Compiler.CodeHeap_Analytics command. So jcmd just exits instead of crashing target VM. Regression test was added, hs-tier1/2 passed. webrev: http://cr.openjdk.java.net/~lmesnik/8225388/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8225388 Leonid