Re: RFR: 8232084: HotSpot build failed with GCC 9.2.1

Wed, 16 Oct 2019 17:10:04 -0700

Hi Yasumasa,

It looks good.
One tip:
+      // This code would be warned as "stringop-truncation" by GCC 8 or later.
+PRAGMA_DIAG_PUSH
+PRAGMA_STRINGOP_TRUNCATION_IGNORED
       strncpy(buf, str, len);
+PRAGMA_DIAG_POP

I'd suggest to place the comment before the line with strncopy().

Not  subject for re-review.

Thanks,
Serguei


On 10/16/19 16:25, Yasumasa Suenaga wrote:
(Re-send email because I could not send original email to serviceability-dev and hotspot-compiler-dev)

Hi,

We discussed the fix for JDK-8232084 in [1], and I think we should fix it with #pragma.
I uploaded new webrev. Could you review it?

  JBS: https://bugs.openjdk.java.net/browse/JDK-8232084
  webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232084/webrev.03/

This change has passed the tests on submit repo (mach5-one-ysuenaga-JDK-8232084-1-20191016-1534-5969882).


Thanks,

Yasumasa


[1] https://mail.openjdk.java.net/pipermail/serviceability-dev/2019-October/029547.html

Reply via email to