Please review the change [1] that ensures that VM and test options are 
forwarded to 
j*-tools when they are launched from serviceability/sa tests.

The tests that expect an empty output  were corrected to ignore the product 
version printed
in the error stream since in some  tiers the tests are run with ' -showversion' 
VM option (tier3).

In test serviceability/sa/TestSysProps.java the code that counts the system 
properties  was  corrected
to ignore the debug output when the test is run with " -Xlog:cds=debug" option 
(tier4).

Testing:  Mach5 tests for tier1 - tier7 passed.

I also run the test with -XComp at Mach5 linux-x64-debug builds before and 
after the changes 
and for  the most of the tests the  overhead is about 2 times although for 
serviceability/sa/sadebugd/SADebugDTest.java it spikes up to 5 times.  Probably 
at least for some tests
it makes to filter out some properties (e.g. -Xcomp) before forwarding them to 
j*-tools.

serviceability/sa/sadebugd/SADebugDTest.java, before : 2m 23s ,  after:11m 07s
serviceability/sa/sadebugd/TestJmapCore.java,  before : 42s ,  after:1m 09s
serviceability/sa/TestSysProps.java, before : 36s ,  after: 1m 27s


[1] http://cr.openjdk.java.net/~dtitov/8242009/webrev.01
[2] https://bugs.openjdk.java.net/browse/JDK-8242009 

Thank you,
Daniil


Reply via email to