On 2020-04-30 11:24, Alan Bateman wrote:
On 30/04/2020 10:07, Stefan Karlsson wrote:
Hi all,
Please review this patch to make it less likely that we accidentally
add or fail to add test.java.opts and test.vm.opts to our spawned
test JVMs.
https://cr.openjdk.java.net/~stefank/8244078/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8244078
We tried a few years ago to get the tests in the libraries areas moved
to using the xxxJava variants of these methods to make it clear that
it exec'ing the java launcher of the JDK under test. Methods such as
executeTestJvm were deprecated as the naming didn't make it clear that
it exec's the java launcher. Looks like some of this has been lost
with the combining of the test infrastructure. So while not directly
to this webrev, I think we need to go back to the naming issue at some
point and avoid having two sets of methods that do the same thing.
Are you specifically referring to executeTestJvm vs executeTestJava?
We could take a step back and look at all these functions and try to
find good names and/or default values. If we're going to clean this up,
I think we need to figure out good and, preferably, concise naming for
all of these:
- create test java launcher with test.*.opts
- create test java launcher without test.*.opts
- execute test java launcher with test.*opts
- execute test java launcher without test.*.opts
Do you want me to hold off on this patch until we've resolved this?
StefanK
-Alan
