On 2020-04-30 12:22, Stefan Karlsson wrote:
Hi David,
On 2020-04-30 11:59, David Holmes wrote:
...
---
test/hotspot/jtreg/gc/arguments/GCArguments.java
Isn't the String[] <-> List<String> conversion already handled in
ProcessTools?
This looks like an area where GC added its own helper utilities early
on and they aren't really needed any more. Future RFE?
I thought the same when I first looked at this, but there's a subtle
withDefaults(...) call in there that filters out some of the passed in
flags.
However, it's weird because it doesn't filter the test.vm.opts and
test.java.opts, only the flags that the tests explicitly passes in. I
think we need to take a closer look at this, as a separate RFE.
I read the disableX part to quickly. This *adds* flags to turn off features.
StefanK
