> On Oct 1, 2020, at 5:53 AM, Erik Österlund <eosterl...@openjdk.java.net> > wrote: > > >> _Mailing list message from [Kim Barrett](mailto:kim.barr...@oracle.com) >> onsrc/hotspot/share/runtime/frame.cpp >> 466 StackFrameStream(JavaThread *thread, bool update, bool process_frames); >> >> Something to consider is that bool parameters like that, especially when >> there are multiple, are error prone. An alternative is distinct enums, which >> likely also obviates the need for comments in calls. > > Coleen also had the same comment, and we agreed to file a follow-up RFE to > clean that up. This also applies to all the > existing parameters passed in. So I would still like to do that, but in a > follow-up RFE. Said RFE will also make the > parameter use in RegisterMap and vframeStream explicit.
That’s fine with me.
