On 06/10/2020 08:22, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
One small thing: the couple of uses of lea(InternalAddress) should really be
adr;
this generates much better code.
diff --git a/src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp
b/src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp
index ce3c97d6746..119bc979e0a 100644
--- a/src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp
+++ b/src/hotspot/cpu/aarch64/c1_CodeStubs_aarch64.cpp
@@ -41,7 +41,7 @@
void C1SafepointPollStub::emit_code(LIR_Assembler* ce) {
__ bind(_entry);
InternalAddress safepoint_pc(ce->masm()->pc() - ce->masm()->offset() +
safepoint_offset());
- __ lea(rscratch1, safepoint_pc);
+ __ adr(rscratch1, safepoint_pc);
__ str(rscratch1, Address(rthread, JavaThread::saved_exception_pc_offset()));
assert(SharedRuntime::polling_page_return_handler_blob() != NULL,
diff --git a/src/hotspot/cpu/aarch64/c2_safepointPollStubTable_aarch64.cpp
b/src/hotspot/cpu/aarch64/c2_safepointPollStubTable_aarch64.cpp
index 1b627172e2d..fb36406fbde 100644
--- a/src/hotspot/cpu/aarch64/c2_safepointPollStubTable_aarch64.cpp
+++ b/src/hotspot/cpu/aarch64/c2_safepointPollStubTable_aarch64.cpp
@@ -39,7 +39,7 @@ void C2SafepointPollStubTable::emit_stub_impl(MacroAssembler&
masm, C2SafepointP
__ bind(entry->_stub_label);
InternalAddress safepoint_pc(masm.pc() - masm.offset() +
entry->_safepoint_offset);
- __ lea(rscratch1, safepoint_pc);
+ __ adr(rscratch1, safepoint_pc);
__ str(rscratch1, Address(rthread, JavaThread::saved_exception_pc_offset()));
__ far_jump(callback_addr);
}
--
Andrew Haley (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
