On Fri, 6 Nov 2020 02:40:44 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Changes from @fisk and @dcubed-ojdk to: >> >> - simplify ObjectMonitor list management >> - get rid of Type-Stable Memory (TSM) >> >> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new >> regressions. >> Aurora Perf runs have also been done (DaCapo-h2, Quick Startup/Footprint, >> SPECjbb2015-Tuned-G1, SPECjbb2015-Tuned-ParGC, Volano) >> - a few minor regressions (<= -0.24%) >> - Volano is 6.8% better >> >> Eric C. has also done promotion perf runs on these bits and says "the >> results look fine". > > Hi Dan, > > Overall this looks great. Comparing old and new code is complex but the new > code on its own is generally much simpler/clearer (not all though :) ). > > I have a few nits, comments and queries below. > > Thanks, > David @dholmes-ora - Thanks for the review! Hmm... I'm not sure why the GitHub UI send out my replies one-at-a-time. Perhaps I should have replied from the "files" view instead of the main PR view? ------------- PR: https://git.openjdk.java.net/jdk/pull/642
