On Fri, 6 Nov 2020 02:40:44 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Resolve more @dholmes-ora comments with help from @fisk. > > Hi Dan, > > Overall this looks great. Comparing old and new code is complex but the new > code on its own is generally much simpler/clearer (not all though :) ). > > I have a few nits, comments and queries below. > > Thanks, > David @dholmes-ora - I'll stick with ceiling for now. If you're satisfied with the changeset, please mark this PR as approved. @fisk - Please mark this PR as approved if you're happy with the current version. @robehn and @coleenp - It would be good to hear from one or both of you... ------------- PR: https://git.openjdk.java.net/jdk/pull/642