On Thu, 19 Nov 2020 15:53:15 GMT, Guoxiong Li
<[email protected]> wrote:
>> Hi all,
>>
>> `TestDriver.java` used `sun.hotspot.WhiteBox.getBooleanVMFlag("Use*GC")`
>> which could return null.
>> This patch uses `sun.hotspot.gc.GC` instead of `sun.hotspot.WhiteBox` to
>> avoid the NullPointerException.
>> Thank you for taking the time to review.
>>
>> Best Regards.
>
> Guoxiong Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use `GC.isSelected` instead of `GC.isSupported`
The changes look good, but I think the fact that when you used `isSupported()`
you didn't see any failures indicates that proper testing was not done with all
GCs. Please be sure to do this testing. In fact you might want to first try
testing with `isSupported()` to confirm that you do see failures.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/1319
