On Thu, 19 Nov 2020 18:03:59 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Guoxiong Li has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use `GC.isSelected` instead of `GC.isSupported` > > Hi Guoxiong, > It looks good to me. > Thanks, > Serguei I run the test locally using the following command before I submit this patch. make test TEST="jtreg:hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java" TEST_VM_OPTS=-XX:+UseShenandoahGC This test passes which misleads me that my patch is right. In any case, I apologize for this mistake and will try my best to do more testing before submitting patches in the future. Thank you very much for taking the time to review. Best Regards. ------------- PR: https://git.openjdk.java.net/jdk/pull/1319
