On Thu, 17 Dec 2020 13:25:42 GMT, Coleen Phillimore <[email protected]> wrote:
>> The error code during class redefinition might be not enough to easily
>> diagnose the problem. Some more logging might be useful to understand it. I
>> encountered this problem when redefined methods with lambda usage.
>> I run all existing tests with enabled logging and sanity verified error
>> messages.
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 935:
>
>> 933: the_class->super()->name() !=
>> 934: scratch_class->super()->name())) {
>> 935: log_trace(redefine, class, normalize)
>
> I think these would be useful to users so that these should be made
> log_info(redefine). All the other redefinition logging is useful for
> developers in debugging redefinition, and a user wouldn't really be able to
> follow the output unless they are very knowledgeable. Making this
> log_info(redefine) would let them see this without the noise of the other
> output.
I've made them log_trace to be consistent with already existing logging
introduced for nestmates related errors. Do you want to make all of them
log_info in such case?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1811
