On Thu, 17 Dec 2020 16:10:29 GMT, Leonid Mesnik <[email protected]> wrote:
>> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 935:
>>
>>> 933: the_class->super()->name() !=
>>> 934: scratch_class->super()->name())) {
>>> 935: log_trace(redefine, class, normalize)
>>
>> I think these would be useful to users so that these should be made
>> log_info(redefine). All the other redefinition logging is useful for
>> developers in debugging redefinition, and a user wouldn't really be able to
>> follow the output unless they are very knowledgeable. Making this
>> log_info(redefine) would let them see this without the noise of the other
>> output.
>
> I've made them log_trace to be consistent with already existing logging
> introduced for nestmates related errors. Do you want to make all of them
> log_info in such case?
I see. I think so, yes. Since you're returning an error from redefinition, a
higher level logging seems warranted.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1811
