On Tue, 2 Feb 2021 23:37:21 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
> We could see NPE on `LinuxCDebugger::loadObjectContainingPC` which is used > mainly by the clhsdb `findpc` command. (See > [JDK-8248876](https://bugs.openjdk.java.net/browse/JDK-8248876) for more > details) > > It is caused by PIE executable handling. > > Currently we use virtual address of top of PT_LOAD in executable as base > address - it is valid for ET_EXEC binary. > However, in case of ET_DYN binary (PIE binary), we should handle it like a > shared library. > In GDB, base address of executable would be calculated by dynamic section. SA > should also do so. Looks good, I made a suggestions elsewhere in the PR about the comments at line 510... ------------- Marked as reviewed by kevinw (Committer). PR: https://git.openjdk.java.net/jdk/pull/2366
