On Thu, 13 May 2021 18:28:24 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> I think maybe the property name of sun.jvm.hotspot.rmi.serverNamePrefix was
> not a good choice, and is making it harder to come up with good argument
> names and syntax. If designing this from scratch, I would have called it
> sun.jvm.hotspot.rmi.serverName, and then appending an optional unique_id to
> it would make more sense.
Agree.
> What if instead of prefix you used servername and possibly also rename
> sun.jvm.hotspot.rmi.serverNamePrefix to sun.jvm.hotspot.rmi.serverName, but
> also keep legacy support in case someone is already using
> sun.jvm.hotspot.rmi.serverNamePrefix and decides to set it?
Sounds good if we can do so! Indeed we need to send CSR for this issue, so we
can do it.
We do not need to think to pass parameters via system properties because we
have SALauncher. So I think against this issue as following. Is it ok?
* Add `--servername` option to debugd
* debugd help describes about this as "instance name of debugd server"
* man page of jhsdb describes that it is used for RMI object name, and
describes "SARemoteDebugger" is set by default.
* Connection string is `[unique_id@]host[:port][/servername]`
* Change the description for `--serverid` in man page to "This is required if
multiple debug servers are run on the same server instance. It would be added
to RMI object name for server instance."
* Will not change the help message because it seems to be enough to
describe abstraction (A unique identifier for this debug server)
* Declare that `sun.jvm.hotspot.rmi.serverNamePrefix` will be deprecated in the
CSR, and show the warning if it is set
-------------
PR: https://git.openjdk.java.net/jdk/pull/3669
