On Sat, 15 May 2021 02:00:15 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> `jhsdb debugd` supports server name prefix with >> `sun.jvm.hotspot.rmi.serverNamePrefix` system property. It will be used as >> remote name for SA RMI object. It is "SARemoteDebugger" by default. >> >> As a result, remote name will be constructed as following: >> >> >> //host[:port]/<serverNamePrefix>['_'<id>] >> >> >> However we have no way to set it excepting system property. jhsdb should >> provide the way to set it as a command line option. >> >> serverNamePrefix is used for RMI object name, so "server name" is more >> suitable for it. Thus I will add `--servername` to `jhsdb debugd` for this >> purpose. >> And also we should add the way to specify it when we connect to debug >> server. I will add it like `--connect id@server:1234/servername`. >> >> I've also filed [CSR for this >> PR](https://bugs.openjdk.java.net/browse/JDK-8265897). Please review it. >> This PR modifies DisableRegistryTest.java, but it has been addressed in >> ProblemList-zgc.txt now. So this PR does not affect ZGC. > > Yasumasa Suenaga has updated the pull request incrementally with one > additional commit since the last revision: > > 8263635: Add --servername option to jhsdb debugd src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/RMIHelper.java line 101: > 99: if (serverNamePrefix != null) { > 100: System.err.println("WARNING: > sun.jvm.hotspot.rmi.serverNamePrefix is deprecated. Please specify it in > --connect."); > 101: rmiObjectName = serverNamePrefix; If the servername was already specified with `--connect`, I would think that we would not want to override it with the property if it is also set. Maybe if both are set then fail with an error. Same in `getName()` below. ------------- PR: https://git.openjdk.java.net/jdk/pull/3669
