On Wed, 9 Jun 2021 13:00:13 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java line >> 81: >> >>> 79: File f = createAttachFile(pid, ns_pid); >>> 80: // Keep a canonical version of File, to delete, in case >>> target process ends and /proc link has gone: >>> 81: File f2 = f.getCanonicalFile(); >> >> Do we need to keep `f`? I think we can replace them to >> `createAttachFile(pid, ns_pid).getCanonicalFile()`. > > That's true, we don't really need them both. Builds and tests OK, thanks. ------------- PR: https://git.openjdk.java.net/jdk/pull/4418
