On Mon, 25 Oct 2021 22:57:35 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> That is one option but I was thinking perhaps remove >> `constants()->release_C_heap_structures()` from >> `instanceKlass::release_C_heap_structures()` and have the callers that >> should remove the CP call `ik->constants()->release_C_heap_structures()` >> directly? >> Or perhaps just change this comment: >> >> >> // Release C heap allocated data that this points to, which includes >> // reference counting symbol names. >> release_C_heap_structures_internal(); >> >> >> to >> >> ` // reference counting symbol names, but excludes the constant pool.` > > Yes, I think that combining release_C_heap_structures and > release_C_heap_structures_internal into single release_C_heap_structures with > a default parameter will simplify code a little bit. But I'm not sure it is > that important and would leave it for you to decide. :) I did not see the last comment from David when added mine. In fact, I like the David's suggestion to call `ik->constants()->release_C_heap_structures()` directly. It looks more simple to me. ------------- PR: https://git.openjdk.java.net/jdk/pull/6105
