On Mon, 11 Oct 2021 09:55:28 GMT, Evgeny Nikitin <eniki...@openjdk.org> wrote:

> This PR contains a relatively simple test which verifies that JVMTI-agents 
> are correctly informed about exceptions caught in C2-compiled code. The 
> 8269574 introduces pre-allocated exceptions in some paths, so the test tries 
> to produce a number of various exceptions and check that provided small JVMTI 
> agent got notified about all of them.

Just a couple of minor issues, not a review of functionality.

test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 28:

> 26:  * @bug 8269574
> 27:  * @summary Verifies that exceptions are reported correctly to JVMTI in 
> the compiled code
> 28:  * @requires vm.jvmti

You also require the JIT

test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 59:

> 57: public class TriggerBuiltinExceptionsTest {
> 58:     private static final WhiteBox WB = WhiteBox.getWhiteBox();
> 59:     private static final int ITERATIONS = 30;           //Arbitrary 
> value, feel free to change

Style nit: space after //

-------------

PR: https://git.openjdk.java.net/jdk/pull/5889

Reply via email to