On Wed, 10 Nov 2021 22:32:34 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Evgeny Nikitin has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Get rid of while-breaks >> - Add JIT requirements >> - Remove explicit type specifiers for own class static calls >> - Remove redundant build directive >> - Merge branch 'master' into JDK-8274982/public >> - 8274982: Add a test for 8269574. > > test/hotspot/jtreg/compiler/jvmti/TriggerBuiltinExceptionsTest.java line 128: > >> 126: >> 127: Asserts.assertEQ( >> 128: TriggerBuiltinExceptionsTest.caughtByJVMTIAgent(), >> caughtByJavaTest, > > What is the reason to use the class name prefix for methods? : > TriggerBuiltinExceptionsTest.compileMethodOrThrow > TriggerBuiltinExceptionsTest.methodToCompile > TriggerBuiltinExceptionsTest.caughtByJVMTIAgent > It is not really needed, tight? Style habits, acquired in previons job... fixed. > test/hotspot/jtreg/compiler/jvmti/libTriggerBuiltinExceptions.cpp line 77: > >> 75: } >> 76: >> 77: } while (false); > > I'm not sure why the while (false) loop is needed. > You can always return JNI_ERR instead of break in all places where the > result != JVMTI_ERROR_NONE is detected and return JNI_OK at the end. > Is it to for one-return style? Remnants from a previous, draft version. Fixed (along with unnecessary 'successfull' variable removal). ------------- PR: https://git.openjdk.java.net/jdk/pull/5889
