On Fri, 4 Mar 2022 22:12:08 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> jdb has 3 types of arguments: > > 1. Those that are jdb specific, such as -attach, -launch, and -listconnectors > 2. Those that are passed to the JVM used to run jdb. These are all prefixed > with -J, and any valid JVM argument can be passed in this manner. > 3. Those that are passed to the debuggee JVM when it is launched, such as > -classpath, -D<property>, and any option that starts with -X (including -XX) > > The problem with the 3rd group is that (other than for -D and -X), jdb will > only pass through arguments that it recognizes, and that list is very > limited. When you want to launch the debuggee with an argument that jdb > doesn't recognize, you have no choice but to launch the debuggee yourself > (using a separate command line and using the -agentlib:jdwp argument) and > then tell jdb to attach to the debuggee process. It's much easier when you > can just let jdb launch the debuggee, and our nsk/jdb testing currently > relies on this feature. > > This PR adds --enable-preview and --add-modules to the list of arguments that > jdb recognizes and passes through to the debuggee JVM. These seem to be the > two most glaring omissions, and are two that will likely be needed soon in > order for loom nsk/jdb testing to work properly. Changes look okay, I'm just not sure if the localised resources should be updated as part of this PR as they are usually done later in the release. ------------- Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/7708
