On Tue, 21 Jun 2022 12:22:46 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> This changes splits thread.hpp/cpp into javaThread, and threads files. >> >> I left the commits intact to see better the progression of changes, but most >> files are include file changes. The only tricky parts are that some files >> were included in thread.hpp, like mutexLocker.cpp, which has to be included >> in the files that need it. >> >> I didn't update the copyrights to save diffs but will before integration. >> Also I won't integrate until after Dan's JDK 19 changes are merged into JDK >> 20. >> >> Tested with tier1-4 on Oracle supported platforms and built on other >> platforms. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit since the last revision: > > Fix Shenandoah build. Thanks David and Robbin. Unfortunately, this change will make backporting more difficult if we have backport changes from JDK 20. I still think it's worth separating the thread files. As a lowly 'vi' user, it's really helpful for me to see whether a field or function belongs to JavaThread or Thread without scrolling up and down the thread.hpp file. I am guessing that there might be fields in one that really belongs in the other. This makes it easier, at least for me, to see. Thank you for the review, Robbin. I'm still waiting for GHA to pass as I forgot about shenandoah and some of the other platforms build differently. Also I'm waiting for @dcubed-ojdk changes to JDK 19 to be integrated and merged into JDK 20 first. ------------- PR: https://git.openjdk.org/jdk/pull/9218
