On Fri, 24 Jun 2022 09:19:33 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
> Update code checks both non-null and instance of a class in jdk.hotspot.agent > module classes. > The checks and explicit casts could also be replaced with pattern matching > for the instanceof operator. > > For example, the following code: > > Object node = tree.getLastSelectedPathComponent(); > if (node != null && node instanceof SimpleTreeNode) { > showInspector((SimpleTreeNode)node); > } > > Can be simplified to: > > Object node = tree.getLastSelectedPathComponent(); > if (node instanceof SimpleTreeNode simpleNode) { > showInspector(simpleNode); > } > > > See similar cleanup in java.base - > [JDK-8258422](https://bugs.openjdk.java.net/browse/JDK-8258422) I noticed you have 3 tier1 JDI tests timing out on all platforms. I don't see this in another PR I just reviewed. I know you didn't change JDI, but am wondering why this is happening in your PR. ------------- PR: https://git.openjdk.org/jdk/pull/9272