On Thu, 30 Jun 2022 19:30:54 GMT, Coleen Phillimore <[email protected]> wrote:
>> Zhengyu Gu has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 27 additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8256811-jdi-missing-class-unloading-event >> - Moved TestClassUnloadEvents.java to new location >> - Fix test >> - Use Shenandoah GC for debuggee for deterministic >> - debug test >> - Adding log for debugging test failure on Windows >> - Removed HiddenClass test from Problem.txt and cleanup test >> - Renamed eventHandler_synthesizeUnloadEvent >> - v5 >> - Improve naming and cleanup >> - ... and 17 more: https://git.openjdk.org/jdk/compare/b5c7df58...a07b3737 > > src/hotspot/share/prims/jvmtiTagMap.cpp line 1144: > >> 1142: heap_object_callback, >> 1143: user_data); >> 1144: Arena dead_object_arena(mtInternal); > > This should be mtServiceability, not Internal. This is an unusual use of > Arena in the JVM. Does it get cleaned up completely when it goes out of scope? Changed mtInternal to mtServiceability. Yes, Arena's destructor calls `destruct_contents()` ------------- PR: https://git.openjdk.org/jdk/pull/9168
