On Sat, 23 Jul 2022 19:41:07 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
> Fixed tests that use eName to print event name to print the class name. Plus > some minor refactoring. I've added a couple of nits. Otherwise, it looks good. Thanks, Serguei test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/request/request001.java line 553: > 551: log3("ERROR: else clause in detecting type of > event1"); > 552: testExitCode = FAILED; > 553: throw new JDITestRuntimeException("** unexpected > event **"); It is better to print the event type (or, at least, something) in this case. test/hotspot/jtreg/vmTestbase/nsk/jdi/EventIterator/nextEvent/nextevent001.java line 543: > 541: log3("ERROR: else clause in detecting type of > event1"); > 542: testExitCode = FAILED; > 543: throw new JDITestRuntimeException("** unexpected > event **"); The same as commented above. ------------- Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.org/jdk/pull/9624